Upgrade to Visual Studio 2026#16170
Open
JunielKatarn wants to merge 11 commits into
Open
Conversation
vmoroz
reviewed
May 21, 2026
| std::future<std::string> LocalBundleReader::LoadBundleAsync(const std::wstring bundleUri) { | ||
| winrt::Windows::Foundation::IAsyncAction LocalBundleReader::LoadBundleAsync( | ||
| const std::wstring bundleUri, | ||
| std::string &result) { |
Member
There was a problem hiding this comment.
It does not look safe if someone would want to use it without thread lock. If we want to keep this function async, then it is better to use IAsyncOperation with hstring.
vmoroz
reviewed
May 21, 2026
| std::future<std::pair<std::string, bool>> GetJavaScriptFromServerAsync(const std::string &url) { | ||
| winrt::Windows::Foundation::IAsyncAction GetJavaScriptFromServerAsync( | ||
| const std::string &url, | ||
| std::pair<std::string, bool> &result) { |
Member
There was a problem hiding this comment.
The same here. We must not use the out parameters with async functions.
Performance Test ResultsBranch: ✅ Passed161 scenario(s) across 28 suite(s) — no regressionsSectionList
FlatList
TouchableOpacity
ScrollView
TouchableHighlight
Pressable
Modal
Image
ActivityIndicator
Switch
Button
TextInput
View
Text
SectionList.native-perf-test.ts
FlatList.native-perf-test.ts
TouchableHighlight.native-perf-test.ts
TouchableOpacity.native-perf-test.ts
Pressable.native-perf-test.ts
ScrollView.native-perf-test.ts
ActivityIndicator.native-perf-test.ts
TextInput.native-perf-test.ts
Switch.native-perf-test.ts
Button.native-perf-test.ts
Modal.native-perf-test.ts
Image.native-perf-test.ts
View.native-perf-test.ts
Text.native-perf-test.ts
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for Visual Studio 2026 (MSVC 14.5).
Type of Change
Erase all that don't apply.
Why
Visual Studio 2026 has reached enouth adoption and maturity to be considered the standard IDE for Windows development.
Keeping Visual Studio 2022 as the default may force developers to have two different VS versions in their computers.
What
std::futureas coroutines to WinRT async types.Microsoft Reviewers: Open in CodeFlow