Skip to content

Fix return Thread node ID in get_review_comments response#2515

Open
juidesai wants to merge 1 commit into
github:mainfrom
juidesai:fix/review-thread-id
Open

Fix return Thread node ID in get_review_comments response#2515
juidesai wants to merge 1 commit into
github:mainfrom
juidesai:fix/review-thread-id

Conversation

@juidesai
Copy link
Copy Markdown

Problem

pull_request_read with method: get_review_comments never returns the thread
node ID (e.g. PRRT_kwDO...). The README documents using this ID with
resolve_thread, making that workflow completely broken.

Root Cause

convertToMinimalReviewThread() in pkg/github/minimal_types.go maps
reviewThreadNodeMinimalReviewThread, but MinimalReviewThread had no
ID field, so thread.ID was silently dropped.

Fix

Added ID string to MinimalReviewThread and populate it via
fmt.Sprintf("%v", thread.ID) in convertToMinimalReviewThread.

Result

get_review_comments now includes "id" on each thread object, enabling the
documented resolve_thread workflow end-to-end.

@juidesai juidesai requested a review from a team as a code owner May 21, 2026 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant