Fix flaky P2 test failures caused by parallel fork lock contention#2943
Open
mirkoalicastro wants to merge 1 commit into
Open
Fix flaky P2 test failures caused by parallel fork lock contention#2943mirkoalicastro wants to merge 1 commit into
mirkoalicastro wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to fix Fix flaky P2 test failures.
Context
lib-extra:testruns withmaxParallelForks = Runtime.runtime.availableProcessors().intdiv(2).Each Gradle test fork is a separate JVM. When multiple forks simultaneously call
model.query(), they race for a process-level file lock causing one of the 2 forks to get an IllegalStateException (P2 operation already in progress).TestP2Provisioneralready has sync mechanism, but that only works within one JVM and not across multiple forks.Fix
Override
maxParallelForks = 1inlib-extra/build.gradle. One fork is enough because theTestP2Provisionersynch handles thread safety within one JVM, and its disk cache ensures P2 deps are provisioned once and reused across all test classes.I don't expect meaningful slowdown since with 2 forks the parallel gain was already lost to lock failures and
testRetryreschedules. Also, I expect this to make the pipeline more stable.