fix(solid-query): Avoid context lookup inside memo#10741
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe PR updates Solid Query's dependency structure and QueryClient resolution. query-devtools declares Solid/Kobalte packages as peer dependencies, and useBaseQuery refactors to retrieve QueryClient directly via context instead of through a wrapper hook. ChangesSolid Query Integration and Dependency Management
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
useQueryClientfrom inside the SolidcreateMemocallback by readingQueryClientContextonce at setup timequeryClientoption behavior before falling back to contextVerification
pnpm --filter @tanstack/solid-query test:types:tscurrentpnpm --filter @tanstack/query-devtools test:types:tscurrentgit diff --checkSummary by CodeRabbit
Release Notes