fix(query-db-collection, trailbase-db-collection): add electric path alias for typecheck#1540
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughTwo package tsconfig.json files (query-db-collection and trailbase-db-collection) add a new TypeScript path alias ChangesTypeScript path alias configuration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…alias Both packages alias @tanstack/db-collection-e2e, whose index re-exports suites that import @tanstack/electric-db-collection — but neither tsconfig had an alias for electric, so fresh-clone typecheck fails.
5024659 to
a360dd6
Compare
Fresh clone of main,
pnpm --filter @tanstack/query-db-collection testerrors out before any test runs — the e2e suites barrel re-exportsmoves.suite.ts/progressive.suite.ts, both of which import@tanstack/electric-db-collection, but the path alias for electric is missing from this tsconfig (and fromtrailbase-db-collection's too).Adding the alias matches the existing pattern. After the change,
pnpm --filter @tanstack/query-db-collection testis back to 190/190.Summary by CodeRabbit