Skip to content

fix(query-db-collection, trailbase-db-collection): add electric path alias for typecheck#1540

Open
leeguooooo wants to merge 1 commit into
TanStack:mainfrom
leeguooooo:fix/query-trailbase-tsconfig-electric-alias
Open

fix(query-db-collection, trailbase-db-collection): add electric path alias for typecheck#1540
leeguooooo wants to merge 1 commit into
TanStack:mainfrom
leeguooooo:fix/query-trailbase-tsconfig-electric-alias

Conversation

@leeguooooo
Copy link
Copy Markdown

@leeguooooo leeguooooo commented May 19, 2026

Fresh clone of main, pnpm --filter @tanstack/query-db-collection test errors out before any test runs — the e2e suites barrel re-exports moves.suite.ts / progressive.suite.ts, both of which import @tanstack/electric-db-collection, but the path alias for electric is missing from this tsconfig (and from trailbase-db-collection's too).

Adding the alias matches the existing pattern. After the change, pnpm --filter @tanstack/query-db-collection test is back to 190/190.

Summary by CodeRabbit

  • Chores
    • Updated TypeScript module path aliases in package configurations to support new module resolution patterns.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 19, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6457ed7d-743c-4429-9622-2d7bd79f6bf5

📥 Commits

Reviewing files that changed from the base of the PR and between 5024659 and a360dd6.

📒 Files selected for processing (2)
  • packages/query-db-collection/tsconfig.json
  • packages/trailbase-db-collection/tsconfig.json

📝 Walkthrough

Walkthrough

Two package tsconfig.json files (query-db-collection and trailbase-db-collection) add a new TypeScript path alias @tanstack/electric-db-collection pointing to ../electric-db-collection/src; the existing @tanstack/db-collection-e2e alias remains.

Changes

TypeScript path alias configuration

Layer / File(s) Summary
Path alias updates for db-collection packages
packages/query-db-collection/tsconfig.json, packages/trailbase-db-collection/tsconfig.json
Both tsconfig files add the @tanstack/electric-db-collection path alias under compilerOptions.paths mapped to ../electric-db-collection/src, preserving the existing @tanstack/db-collection-e2e alias.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I hopped through config trails tonight,
Adding a path so imports take flight,
Electric and e2e side by side,
Workspace maps now smoothly guide,
A tiny tweak — the build feels light.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description explains the problem, solution, and verification, but lacks completion of the required checklist items from the template. Complete the checklist by confirming test status and whether a changeset was generated, or clarify why these items are not applicable.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: adding the electric path alias to TypeScript configurations for two packages.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

…alias

Both packages alias @tanstack/db-collection-e2e, whose index re-exports
suites that import @tanstack/electric-db-collection — but neither
tsconfig had an alias for electric, so fresh-clone typecheck fails.
@leeguooooo leeguooooo force-pushed the fix/query-trailbase-tsconfig-electric-alias branch from 5024659 to a360dd6 Compare May 19, 2026 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant