[Performance] Memoize shouldDisplayColors#7595
Conversation
Memoize the result of `shouldDisplayColors` when called with the default `process` to avoid redundant environment lookups and TTY checks in high-frequency logging paths.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
WHY are these changes introduced?
High-frequency logging paths call
shouldDisplayColorsrepeatedly to determine if output should be colorized. Accessingprocess.envand checking TTY status onprocess.stdoutinvolves small but measurable overhead that adds up over the lifecycle of a CLI command, especially when debug logging is enabled or many messages are processed.WHAT is this pull request doing?
This PR introduces memoization for the
shouldDisplayColorsfunction in@shopify/cli-kit.processobject.How to test your changes?
CI
Post-release steps
None.
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 303941856508991664 started by @gonzaloriestra