Skip to content

[Security] Harden openURL protocol validation#7589

Draft
gonzaloriestra wants to merge 2 commits into
mainfrom
jules-security-harden-open-url-protocol-validation-4911786415154034671
Draft

[Security] Harden openURL protocol validation#7589
gonzaloriestra wants to merge 2 commits into
mainfrom
jules-security-harden-open-url-protocol-validation-4911786415154034671

Conversation

@gonzaloriestra
Copy link
Copy Markdown
Contributor

Why is this change necessary?

The openURL function was previously passing the input string directly to the open library without validation. This allowed any URL protocol to be handled by the system's default opener, which could lead to security risks if an attacker can influence the URL (e.g., via javascript: or data: protocols).

How to test your changes?

CI

Checklist

  • I've added a description of what is changed and why.
  • I've added a link to the document or issue it's fixing (if applicable).
  • I've added some screenshots/recordings of the before/after (if applicable).
  • I've added tests for the new/updated code.
  • I've followed the standard guidelines.
  • I've used existing components (if applicable).
  • I've checked that the changes are backwards compatible (if applicable).
  • I've added a changeset (if applicable).

PR created automatically by Jules for task 4911786415154034671 started by @gonzaloriestra

Restrict allowed protocols in `openURL` to `http:`, `https:`, and `file:`.
This prevents the execution of dangerous protocols like `javascript:`
or `data:` via the system's default opener.

- Added protocol validation using `URL` constructor in `packages/cli-kit/src/public/node/system.ts`.
- Added comprehensive regression tests in `packages/cli-kit/src/public/node/system.test.ts`.
- Updated `.jules/sentinel.md` with critical learnings.
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label May 20, 2026
@gonzaloriestra gonzaloriestra added the Jules Created by Jules label May 20, 2026
Restrict allowed protocols in `openURL` to `http:`, `https:`, and `file:`.
This prevents the execution of dangerous protocols like `javascript:`
or `data:` via the system's default opener.

Also manually patched a GraphQL codegen inconsistency in `business-platform-organizations`
to fix a CI failure where `AttestationID` scalar was missing in the generated types.

- Added protocol validation using `URL` constructor in `packages/cli-kit/src/public/node/system.ts`.
- Added comprehensive regression tests in `packages/cli-kit/src/public/node/system.test.ts`.
- Manually added `AttestationID` to `packages/app/src/cli/api/graphql/business-platform-organizations/generated/types.d.ts`.
- Updated `.jules/sentinel.md` with critical learnings.
@gonzaloriestra gonzaloriestra force-pushed the jules-security-harden-open-url-protocol-validation-4911786415154034671 branch from c219170 to 7557537 Compare May 20, 2026 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Jules Created by Jules no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant