[Refactor] Simplify mkTmpDir in cli-kit#7587
Conversation
Refactor `mkTmpDir` in `packages/cli-kit/src/public/node/fs.ts` to use `systemTempDir` and `joinPath` for consistency with other temporary directory functions like `tempDirectory` and `inTemporaryDirectory`. Simplified the implementation by returning the `fsMkdtemp` promise directly and removing an unnecessary intermediate variable.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Refactor `mkTmpDir` in `packages/cli-kit/src/public/node/fs.ts` to use `systemTempDir` and `join` for consistency with other temporary directory functions like `tempDirectory` and `inTemporaryDirectory`. Simplified the implementation by returning the `fsMkdtemp` promise directly and removing an unnecessary intermediate variable.
Refactor `mkTmpDir` to use `systemTempDir` and `join` for consistency with other temporary directory functions in the same module. Removed unnecessary intermediate variable.
Refactor `mkTmpDir` in `packages/cli-kit/src/public/node/fs.ts` to use `systemTempDir` and `join` for consistency with other temporary directory functions like `tempDirectory` and `inTemporaryDirectory`. Simplified the implementation by returning the `fsMkdtemp` promise directly and removing an unnecessary intermediate variable.
dfd28a7 to
105f071
Compare
This PR simplifies the
mkTmpDirfunction in@shopify/cli-kit.os.tmpdir()withsystemTempDirto match other temporary directory utilities.joinPathconsistently for path joining.PR created automatically by Jules for task 11967171989926349973 started by @gonzaloriestra