Skip to content

[Refactor] Simplify mkTmpDir in cli-kit#7587

Draft
gonzaloriestra wants to merge 4 commits into
mainfrom
jules-refactor-simplify-mktmpdir-11967171989926349973
Draft

[Refactor] Simplify mkTmpDir in cli-kit#7587
gonzaloriestra wants to merge 4 commits into
mainfrom
jules-refactor-simplify-mktmpdir-11967171989926349973

Conversation

@gonzaloriestra
Copy link
Copy Markdown
Contributor

This PR simplifies the mkTmpDir function in @shopify/cli-kit.

  • Replaces os.tmpdir() with systemTempDir to match other temporary directory utilities.
  • Uses joinPath consistently for path joining.
  • Removes an unnecessary intermediate variable and returns the promise directly.

PR created automatically by Jules for task 11967171989926349973 started by @gonzaloriestra

Refactor `mkTmpDir` in `packages/cli-kit/src/public/node/fs.ts` to use `systemTempDir` and `joinPath` for consistency with other temporary directory functions like `tempDirectory` and `inTemporaryDirectory`. Simplified the implementation by returning the `fsMkdtemp` promise directly and removing an unnecessary intermediate variable.
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label May 20, 2026
Refactor `mkTmpDir` in `packages/cli-kit/src/public/node/fs.ts` to use `systemTempDir` and `join` for consistency with other temporary directory functions like `tempDirectory` and `inTemporaryDirectory`. Simplified the implementation by returning the `fsMkdtemp` promise directly and removing an unnecessary intermediate variable.
Refactor `mkTmpDir` to use `systemTempDir` and `join` for consistency with other temporary directory functions in the same module. Removed unnecessary intermediate variable.
@gonzaloriestra gonzaloriestra added the Jules Created by Jules label May 20, 2026
Refactor `mkTmpDir` in `packages/cli-kit/src/public/node/fs.ts` to use `systemTempDir` and `join` for consistency with other temporary directory functions like `tempDirectory` and `inTemporaryDirectory`. Simplified the implementation by returning the `fsMkdtemp` promise directly and removing an unnecessary intermediate variable.
@gonzaloriestra gonzaloriestra force-pushed the jules-refactor-simplify-mktmpdir-11967171989926349973 branch from dfd28a7 to 105f071 Compare May 20, 2026 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Jules Created by Jules no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant