[Tests] Remove filesystem mocks in copy-by-pattern.test.ts#7580
[Tests] Remove filesystem mocks in copy-by-pattern.test.ts#7580gonzaloriestra wants to merge 1 commit into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Refactor copy-by-pattern.test.ts to use real filesystem operations via inTemporaryDirectory instead of mocking @shopify/cli-kit/node/fs. This ensures the tests verify actual disk interactions and path resolution behavior.
78d9eb9 to
b5d9e74
Compare
WHY are these changes introduced?
Mocks for the filesystem can lead to tests that pass but don't actually verify the real behavior of the code on disk. This is especially true for services that use
fileRealPathor other operations that depend on path existence.WHAT is this pull request doing?
Refactors
packages/app/src/cli/services/build/steps/include-assets/copy-by-pattern.test.tsto remove globalvi.mock('@shopify/cli-kit/node/fs'). It now usesinTemporaryDirectoryand real filesystem operations (mkdir,writeFile,fileExists) to verify the behavior of thecopyByPatternservice.How to test your changes?
CI
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 5074333505735786815 started by @gonzaloriestra