Skip to content

[Tests] Remove filesystem mocks in copy-by-pattern.test.ts#7580

Draft
gonzaloriestra wants to merge 1 commit into
mainfrom
jules-tests-remove-fs-mocks-copy-by-pattern-5074333505735786815
Draft

[Tests] Remove filesystem mocks in copy-by-pattern.test.ts#7580
gonzaloriestra wants to merge 1 commit into
mainfrom
jules-tests-remove-fs-mocks-copy-by-pattern-5074333505735786815

Conversation

@gonzaloriestra
Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

Mocks for the filesystem can lead to tests that pass but don't actually verify the real behavior of the code on disk. This is especially true for services that use fileRealPath or other operations that depend on path existence.

WHAT is this pull request doing?

Refactors packages/app/src/cli/services/build/steps/include-assets/copy-by-pattern.test.ts to remove global vi.mock('@shopify/cli-kit/node/fs'). It now uses inTemporaryDirectory and real filesystem operations (mkdir, writeFile, fileExists) to verify the behavior of the copyByPattern service.

How to test your changes?

CI

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

PR created automatically by Jules for task 5074333505735786815 started by @gonzaloriestra

@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label May 19, 2026
@gonzaloriestra gonzaloriestra added the Jules Created by Jules label May 20, 2026
Refactor copy-by-pattern.test.ts to use real filesystem operations
via inTemporaryDirectory instead of mocking @shopify/cli-kit/node/fs.
This ensures the tests verify actual disk interactions and path
resolution behavior.
@gonzaloriestra gonzaloriestra force-pushed the jules-tests-remove-fs-mocks-copy-by-pattern-5074333505735786815 branch from 78d9eb9 to b5d9e74 Compare May 20, 2026 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Jules Created by Jules no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant