Skip to content

[Security] Fix locale-sensitive header redaction#7572

Open
gonzaloriestra wants to merge 1 commit into
mainfrom
jules-security-fix-locale-header-redaction-14224719727929470904
Open

[Security] Fix locale-sensitive header redaction#7572
gonzaloriestra wants to merge 1 commit into
mainfrom
jules-security-fix-locale-header-redaction-14224719727929470904

Conversation

@gonzaloriestra
Copy link
Copy Markdown
Contributor

@gonzaloriestra gonzaloriestra commented May 18, 2026

WHY are these changes introduced?

Redaction of sensitive headers (like `AUTHORIZATION`) could be bypassed on systems with certain locales (e.g., Turkish) because `toLocaleLowerCase()` is non-deterministic for ASCII characters like 'I' (which becomes 'ı' in Turkish).

WHAT is this pull request doing?

This PR replaces `toLocaleLowerCase()` with `toLowerCase()` in `sanitizedHeadersOutput` to ensure consistent ASCII-based matching for HTTP headers regardless of the user's locale. It also adds a regression test that simulates the problematic locale behavior.

How to test your changes?

CI

Post-release steps

None.

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (`patch` for bug fixes · `minor` for new features · `major` for breaking changes) and added a changeset with `pnpm changeset add`

PR created automatically by Jules for task 14224719727929470904 started by @gonzaloriestra

@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label May 18, 2026
@gonzaloriestra gonzaloriestra added the Jules Created by Jules label May 18, 2026
@gonzaloriestra gonzaloriestra marked this pull request as ready for review May 18, 2026 12:04
@gonzaloriestra gonzaloriestra requested a review from a team as a code owner May 18, 2026 12:04
Comment thread .jules/sentinel.md Outdated
Comment thread packages/cli-kit/src/private/node/api/headers.test.ts
@gonzaloriestra gonzaloriestra force-pushed the jules-security-fix-locale-header-redaction-14224719727929470904 branch 2 times, most recently from 52250b4 to fcff081 Compare May 20, 2026 13:17
@gonzaloriestra gonzaloriestra requested a review from a team as a code owner May 20, 2026 13:28
@gonzaloriestra gonzaloriestra force-pushed the jules-security-fix-locale-header-redaction-14224719727929470904 branch 2 times, most recently from 676f52c to 204f986 Compare May 20, 2026 13:50
@github-actions
Copy link
Copy Markdown
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/private/node/ui/components/AutocompletePrompt.d.ts
@@ -20,13 +20,6 @@ export interface AutocompletePromptProps<T> {
     abortSignal?: AbortSignal;
     infoMessage?: InfoMessageProps['message'];
     groupOrder?: string[];
-    /**
-     * Throttle window in milliseconds applied to the search callback. Defaults to 400ms,
-     * which is appropriate for remote/paginated backends. In-memory consumers (where the
-     * search callback resolves synchronously) can pass 0 for instant filtering on every
-     * keystroke.
-     */
-    searchDebounceMs?: number;
 }
-declare function AutocompletePrompt<T>({ message, choices, infoTable, onSubmit, search, hasMorePages: initialHasMorePages, abortSignal, infoMessage, groupOrder, searchDebounceMs, }: React.PropsWithChildren<AutocompletePromptProps<T>>): ReactElement | null;
+declare function AutocompletePrompt<T>({ message, choices, infoTable, onSubmit, search, hasMorePages: initialHasMorePages, abortSignal, infoMessage, groupOrder, }: React.PropsWithChildren<AutocompletePromptProps<T>>): ReactElement | null;
 export { AutocompletePrompt };
\ No newline at end of file

@gonzaloriestra gonzaloriestra force-pushed the jules-security-fix-locale-header-redaction-14224719727929470904 branch 2 times, most recently from 2905c0b to 30ee0f6 Compare May 20, 2026 13:59
Replaced toLocaleLowerCase() with toLowerCase() in sanitizedHeadersOutput
to ensure consistent redaction of sensitive headers regardless of the
system locale. Added a regression test simulating the Turkish locale
issue.

Also manually updated graphql types to resolve CI inconsistency.
@gonzaloriestra gonzaloriestra force-pushed the jules-security-fix-locale-header-redaction-14224719727929470904 branch from 30ee0f6 to fc39f9c Compare May 20, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Jules Created by Jules no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants