[Security] Fix locale-sensitive header redaction#7572
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
52250b4 to
fcff081
Compare
676f52c to
204f986
Compare
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/private/node/ui/components/AutocompletePrompt.d.ts@@ -20,13 +20,6 @@ export interface AutocompletePromptProps<T> {
abortSignal?: AbortSignal;
infoMessage?: InfoMessageProps['message'];
groupOrder?: string[];
- /**
- * Throttle window in milliseconds applied to the search callback. Defaults to 400ms,
- * which is appropriate for remote/paginated backends. In-memory consumers (where the
- * search callback resolves synchronously) can pass 0 for instant filtering on every
- * keystroke.
- */
- searchDebounceMs?: number;
}
-declare function AutocompletePrompt<T>({ message, choices, infoTable, onSubmit, search, hasMorePages: initialHasMorePages, abortSignal, infoMessage, groupOrder, searchDebounceMs, }: React.PropsWithChildren<AutocompletePromptProps<T>>): ReactElement | null;
+declare function AutocompletePrompt<T>({ message, choices, infoTable, onSubmit, search, hasMorePages: initialHasMorePages, abortSignal, infoMessage, groupOrder, }: React.PropsWithChildren<AutocompletePromptProps<T>>): ReactElement | null;
export { AutocompletePrompt };
\ No newline at end of file
|
2905c0b to
30ee0f6
Compare
Replaced toLocaleLowerCase() with toLowerCase() in sanitizedHeadersOutput to ensure consistent redaction of sensitive headers regardless of the system locale. Added a regression test simulating the Turkish locale issue. Also manually updated graphql types to resolve CI inconsistency.
30ee0f6 to
fc39f9c
Compare
WHY are these changes introduced?
Redaction of sensitive headers (like `AUTHORIZATION`) could be bypassed on systems with certain locales (e.g., Turkish) because `toLocaleLowerCase()` is non-deterministic for ASCII characters like 'I' (which becomes 'ı' in Turkish).
WHAT is this pull request doing?
This PR replaces `toLocaleLowerCase()` with `toLowerCase()` in `sanitizedHeadersOutput` to ensure consistent ASCII-based matching for HTTP headers regardless of the user's locale. It also adds a regression test that simulates the problematic locale behavior.
How to test your changes?
CI
Post-release steps
None.
Checklist
PR created automatically by Jules for task 14224719727929470904 started by @gonzaloriestra