[Security] Harden URL sanitization#7564
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
5164c34 to
3b57dc2
Compare
This PR enhances `sanitizeURL` to redact passwords from the URL authority and includes more sensitive query parameters (like `code_verifier`, `password`, and `assertion`) in the redaction list. This reduces the risk of sensitive credentials being leaked in debug logs or error messages. ### How to test your changes? CI. (Internal utility `sanitizeURL` is now verified by expanded unit tests).
3b57dc2 to
f5f9fe4
Compare
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/private/node/api/urls.d.ts@@ -1,6 +1,6 @@
/**
* Removes the sensitive data from the url and outputs them as a string.
- * @param url - HTTP headers.
+ * @param url - The URL to sanitize.
* @returns A sanitized version of the url as a string.
*/
export declare function sanitizeURL(url: string): string;
\ No newline at end of file
|
Why is this change necessary?
Currently,
sanitizeURLredacts some sensitive query parameters but misses several others commonly used in OAuth 2.0 and authentication flows. It also fails to redact passwords in the URL authority (Basic Auth), which are preserved by theURLobject.Internal Consideration
This change hardens a core utility used for logging URLs, ensuring better protection against accidental credential leakage.
Checklist
PR created automatically by Jules for task 3281329784931291247 started by @gonzaloriestra