Skip to content

[Security] Harden URL sanitization#7564

Draft
gonzaloriestra wants to merge 1 commit into
mainfrom
jules-security-harden-url-sanitization-3281329784931291247
Draft

[Security] Harden URL sanitization#7564
gonzaloriestra wants to merge 1 commit into
mainfrom
jules-security-harden-url-sanitization-3281329784931291247

Conversation

@gonzaloriestra
Copy link
Copy Markdown
Contributor

Why is this change necessary?

Currently, sanitizeURL redacts some sensitive query parameters but misses several others commonly used in OAuth 2.0 and authentication flows. It also fails to redact passwords in the URL authority (Basic Auth), which are preserved by the URL object.

Internal Consideration

This change hardens a core utility used for logging URLs, ensuring better protection against accidental credential leakage.

Checklist


PR created automatically by Jules for task 3281329784931291247 started by @gonzaloriestra

@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label May 17, 2026
@gonzaloriestra gonzaloriestra added the Jules Created by Jules label May 18, 2026
Comment thread packages/cli-kit/src/private/node/api/urls.test.ts
Comment thread packages/cli-kit/src/private/node/api/urls.ts
@gonzaloriestra gonzaloriestra force-pushed the jules-security-harden-url-sanitization-3281329784931291247 branch from 5164c34 to 3b57dc2 Compare May 20, 2026 12:52
This PR enhances `sanitizeURL` to redact passwords from the URL authority and includes more sensitive query parameters (like `code_verifier`, `password`, and `assertion`) in the redaction list. This reduces the risk of sensitive credentials being leaked in debug logs or error messages.

### How to test your changes?

CI. (Internal utility `sanitizeURL` is now verified by expanded unit tests).
@gonzaloriestra gonzaloriestra force-pushed the jules-security-harden-url-sanitization-3281329784931291247 branch from 3b57dc2 to f5f9fe4 Compare May 20, 2026 13:17
@github-actions
Copy link
Copy Markdown
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/private/node/api/urls.d.ts
@@ -1,6 +1,6 @@
 /**
  * Removes the sensitive data from the url and outputs them as a string.
- * @param url - HTTP headers.
+ * @param url - The URL to sanitize.
  * @returns A sanitized version of the url as a string.
  */
 export declare function sanitizeURL(url: string): string;
\ No newline at end of file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Jules Created by Jules no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants