feat(dbm): add dynamic_service propagation mode#8592
Open
amarziali wants to merge 1 commit into
Open
Conversation
amarziali
requested review from
crysmags and
raphaelgavache
and removed request for
a team
Contributor
Overall package sizeSelf size: 5.84 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.0.1 | 82.56 kB | 817.39 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | dc-polyfill | 0.1.11 | 25.74 kB | 25.74 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Introduces a new value for
DD_DBM_PROPAGATION_MODE:dynamic_service.Setting
DD_DBM_PROPAGATION_MODE=dynamic_serviceis a convenience shorthand that combines the behavior of two separate settings:DD_DBM_PROPAGATION_MODE=service— injects a DBM SQL comment with service-level tags (dddb,dddbs,dde,ddh,ddps,ddpv)DD_DBM_INJECT_SQL_BASEHASH=true— additionally injects the propagation hash (ddsh) when process tags are enabledWith
dynamic_service, users get hash injection automatically without needing to setDD_DBM_INJECT_SQL_BASEHASH=truealongside the propagation mode.Motivation
Additional Notes
System tests are provided in this PR: DataDog/system-tests#6997