Skip to content

rfc3986 uses its own deprecated method - warning spam #123

@jpmaterial

Description

@jpmaterial

In Version 2.0, in URIMixin.resolve_with() rfc3986 uses the deprecated URIReference.is_valid() instead of a Validator.

Apart from it being a bad look, it causes literally thousands of warnings in our pipeline (since resolve_with() is used often from the json-schema and jschon packages) - see below. This spams our logs and can make it hard to debug.

I made a fix: https://github.com/jpmaterial/rfc3986/tree/release/2.0 (and verified it), but there is no branch that offers itself for a pull request.

Are you interested in the fix (and releasing a 2.0.1 I guess) and if yes, on which branch should I request a pull?

image

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions